-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dual rhs2116 device #224
Closed
Closed
Dual rhs2116 device #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jonnew
commented
Aug 16, 2024
- Attempt at Abstract device combinations #122
- This is a draft because its non-functional for reasons unknow
- Support acquisition from RHS2116, writing filter settings, etc. - Does not have the ability to configure or trigger stimulus sequences and does not yet include a Rhs2116TriggerDevice in ConfigureHeadstageRhs2116. GUI support will be critical for this.
- Add stimulus trigger device to headstage - Add stimulus sequence definition to RHS2116 configuration - This will require GUI support for configuring the stimulus waveform. - Tested with hardcoded stimulus parameters and it works great.
- Stimulus trigger device accepts a delay in microsends to the applicatin of a stimulus - Mark CheckLinkStatus as virtual so headstage can be reset between power cycles (see #120) - Rebase main and take advantage of latest improvments with respect to port voltage override
- The voltage drop is what it is. Im getting reliable locking with this the algorithm that is implemented in ConfigureHeadstageRhs2116LinkController
- Support acquisition from RHS2116, writing filter settings, etc. - Does not have the ability to configure or trigger stimulus sequences and does not yet include a Rhs2116TriggerDevice in ConfigureHeadstageRhs2116. GUI support will be critical for this.
- Add stimulus trigger device to headstage - Add stimulus sequence definition to RHS2116 configuration - This will require GUI support for configuring the stimulus waveform. - Tested with hardcoded stimulus parameters and it works great.
- Stimulus trigger device accepts a delay in microsends to the applicatin of a stimulus - Mark CheckLinkStatus as virtual so headstage can be reset between power cycles (see #120) - Rebase main and take advantage of latest improvments with respect to port voltage override
- The voltage drop is what it is. Im getting reliable locking with this the algorithm that is implemented in ConfigureHeadstageRhs2116LinkController
- Up to date with frame distribution, DeviceType, etc.
- Deleted bracket by accident - Incorrectly removed virtual keywork from CheckLinkStatus function declaration
- This is a non-functional draft - On headstage-rhs2116, rhs2116 frames are produced in an interleaved fashion without fifos that could cause delays or multiple frames from a single device to be sent in sequence. Therefore, their frames can be gathered in order to make a virtual, 32-channel verison of the chip. This commits attempts to an fails to do this for the reasons outline in #122
Moved to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.