Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NeuropixelsV2eBeta GUIs #269

Merged
merged 2 commits into from
Sep 4, 2024
Merged

Add NeuropixelsV2eBeta GUIs #269

merged 2 commits into from
Sep 4, 2024

Conversation

bparks13
Copy link
Member

This PR adds GUIs for the NeuropixelsV2eBeta headstage. The added dialogs call the NeuropixelsV2e GUIs, taking advantage of the common interface between ConfigureNeuropixelsV2e and ConfigureNeuropixelsV2eBeta. When the underlying type is a *Beta, all relevant text strings are updated to reflect this.

Closes #227
Closes #268
Fixes #202

- V2e and V2eBeta inherit from this interface
- Modified V2e dialogs to accept the interface
- V2eBeta operators call the V2e dialogs, due to the common interface, and modify strings as needed to specify 'Beta'
@bparks13 bparks13 added the feature New planned feature label Aug 28, 2024
@bparks13 bparks13 added this to the 0.3.0 milestone Aug 28, 2024
@bparks13 bparks13 requested a review from jonnew August 28, 2024 16:28
@bparks13 bparks13 self-assigned this Aug 28, 2024
- Consolidated XML comments, now the summary is inherited from the interface for shared properties of NeuropixelsV2 devices
@bparks13 bparks13 requested a review from jonnew August 28, 2024 16:53
Copy link
Member

@jonnew jonnew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran GUIs, configured channels etc. All seems good.

@jonnew jonnew merged commit 0fcdd85 into main Sep 4, 2024
7 checks passed
@jonnew jonnew deleted the issue-268 branch September 4, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New planned feature
Projects
None yet
2 participants