Multi-platform support #30
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removed the Makefile.osx specific files, added a check for the `uname` and modified commands based on the output - Note that this is not guaranteed to work on Windows, since there is not a `uname` built into the terminal there, but since this Makefile should only be used for Mac or Linux it should be fine
- Small makefile fixes - Enabe static compiling of ftdi library for easier distribution
Fix macOS build errors
jonnew
reviewed
Jan 30, 2025
| @@ -4,8 +4,17 @@ NAME := oni-repl | |||
| SRC := main.c | |||
| OBJ := $(SRC:.c=.o) | |||
| CFLAGS := -pedantic -Wall -W -Werror -fPIC -O3 $(DEFS) | |||
| LDFLAGS := -lm -lpthread -loni -ldl | |||
| # LDFLAGS := -lm -lpthread -loni -ldl | |||
There was a problem hiding this comment.
would prefer that a final decision is made since things like this can cause confusion in the future
jonnew
reviewed
Jan 30, 2025
| @@ -73,7 +75,7 @@ int oni_create_driver(const char* lib_name, oni_driver_t* driver) | |||
| free(full_lib_name); | |||
|
|
|||
| if (!handle) { | |||
| // fprintf(stderr, "Failed to load driver: %s\n", dlerror()); | |||
| // fprintf(stderr, "Failed to load driver: %s\n", dlerror()); | |||
There was a problem hiding this comment.
wrap in #ifndef NDEBUG and uncomment? or remove?
jonnew
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reviews multi-platform support for liboni and, specially, the ft600 driver translator: