-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed 3 typos #23
Fixed 3 typos #23
Conversation
3 small typos were fixed in the document. Signed-off-by: decoder <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Piotr1215 You may want to add suggestions in #22
Simultaneously spanning before and after you submitted here, all 3 typos:
- acheived -> achieved
- occured -> occurred
- configiuration -> configuration
are now also suggested for correction in RC2 draft 🎈 #22
Since I agree with all 3 typo fixes presented here, I approved this pull request. Practically-speaking, your proposed changes may end up being folded into #22 which now have the same 3 typo fixes in aggregate. This depends on how @scottrigby wants to process both pull requests #22 and #23.
Thank you @Piotr1215 and @scottrigby
🚀 Thank you @Piotr1215 @todaywasawesome @scottrigby |
Thank you for explaining @lloydchang. The reason I did a patch was that I had no access to comment on code for #22 , but I could always mention in what file the typos were. |
@Piotr1215 I believe the access issue is because of:
|
Related, #22 (comment)
@scottrigby, if you want to add the 3 co-authors, they are:
|
Hi, apologies if those were already found, but I've spotted those 3 typos.
I'm not sure if the patch is the right way to contribute, if not please LMK.