Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed 3 typos #23

Merged
merged 1 commit into from
Sep 27, 2021
Merged

Fixed 3 typos #23

merged 1 commit into from
Sep 27, 2021

Conversation

Piotr1215
Copy link

Hi, apologies if those were already found, but I've spotted those 3 typos.

I'm not sure if the patch is the right way to contribute, if not please LMK.

3 small typos were fixed in the document.

Signed-off-by: decoder <[email protected]>
Copy link
Contributor

@lloydchang lloydchang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Piotr1215 You may want to add suggestions in #22

Simultaneously spanning before and after you submitted here, all 3 typos:

  1. acheived -> achieved
  2. occured -> occurred
  3. configiuration -> configuration
    are now also suggested for correction in RC2 draft 🎈  #22

Since I agree with all 3 typo fixes presented here, I approved this pull request. Practically-speaking, your proposed changes may end up being folded into #22 which now have the same 3 typo fixes in aggregate. This depends on how @scottrigby wants to process both pull requests #22 and #23.

Thank you @Piotr1215 and @scottrigby

@todaywasawesome todaywasawesome merged commit 42f02d6 into open-gitops:rc2-draft Sep 27, 2021
@todaywasawesome todaywasawesome mentioned this pull request Sep 27, 2021
3 tasks
@lloydchang
Copy link
Contributor

🚀 Thank you @Piotr1215 @todaywasawesome @scottrigby

@Piotr1215
Copy link
Author

@Piotr1215 You may want to add suggestions in #22
Since I agree with all 3 typo fixes presented here, I approved this pull request. Practically-speaking, your proposed changes may end up being folded into #22 which now have the same 3 typo fixes in aggregate. This depends on how @scottrigby wants to process both pull requests #22 and #23.

Thank you for explaining @lloydchang. The reason I did a patch was that I had no access to comment on code for #22 , but I could always mention in what file the typos were.

@scottrigby scottrigby added this to the v1.0.0-rc.2 milestone Sep 29, 2021
@lloydchang
Copy link
Contributor

@Piotr1215 I believe the access issue is because of:

We went looking everywhere, but couldn’t find those commits. Sometimes commits can disappear after a force-push. Head back to the latest changes here.

Here's a screenshot of what I see when that happens:
We went looking everywhere, but couldn’t find those commits  Sometimes commits can disappear after a force-push  Head back to the latest changes here

@lloydchang
Copy link
Contributor

Related, #22 (comment)

I think we should add Co-authored-by trailers to the commit from #23, since it was recommended here as well. We can still rewrite commits in this PR branch before anything gets committed to main.

@scottrigby, if you want to add the 3 co-authors, they are:

  1. @squaremo for "achieved"
  2. @ckavili for "configuration"
  3. @lloydchang for "occurred"

@Piotr1215 Piotr1215 deleted the patch-1 branch September 30, 2021 19:44
@scottrigby scottrigby added the bug Something isn't working label Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants