fix: fixing panic in debug log #3244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jaydip Gabani <[email protected]>
|
@maxsmythe @sozercan lets get this in before the actual release. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3244 +/- ##
==========================================
- Coverage 54.47% 54.45% -0.02%
==========================================
Files 134 134
Lines 12329 12329
==========================================
- Hits 6716 6714 -2
- Misses 5119 5120 +1
- Partials 494 495 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
JaydipGabani
added a commit
to JaydipGabani/gatekeeper
that referenced
this pull request
Jan 31, 2024
Signed-off-by: Jaydip Gabani <[email protected]> (cherry picked from commit 88033b1)
ritazh
reviewed
Jan 31, 2024
| @@ -515,7 +515,7 @@ func (am *Manager) auditFromCache(ctx context.Context) ([]Result, []error) { | |||
| } | |||
|
|
|||
| if excluded { | |||
| am.log.V(logging.DebugLevel).Info("excluding object from audit from cache %v %s/%s", obj.GroupVersionKind().String(), obj.GetNamespace(), obj.GetName()) | |||
| am.log.V(logging.DebugLevel).Info(fmt.Sprintf("excluding object from audit from cache %v %s/%s", obj.GroupVersionKind().String(), obj.GetNamespace(), obj.GetName())) | |||
There was a problem hiding this comment.
@JaydipGabani Good catch!
Can you please scan this file for other occurrences of this?
https://github.com/open-policy-agent/gatekeeper/pull/3244/files#diff-2a233457fc5c89cf0dd91c044d7582aa1cc0c835feabf4638882ac54ba3ca63aR528
JaydipGabani
added a commit
that referenced
this pull request
Jan 31, 2024
leewoobin789
pushed a commit
to softlee-io/gatekeeper
that referenced
this pull request
Apr 1, 2024
Signed-off-by: Jaydip Gabani <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Debug log is causing panic due to odd number of key/value passed.
Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when the PR gets merged):Fixes #
Special notes for your reviewer: