chore: Add pods/resize subresource to mutating and validating webhooks
#3778
Conversation
Signed-off-by: Ian Stanton <[email protected]>
Signed-off-by: Ian Stanton <[email protected]>
Signed-off-by: Ian Stanton <[email protected]>
Signed-off-by: Ian Stanton <[email protected]>
There was a problem hiding this comment.
Can you also add the list of subresources for mutating-webhook-configuration as well?
- pods/ephemeralcontainers
- pods/exec
- pods/log
- pods/eviction
- pods/portforward
- pods/proxy
- pods/attach
- pods/binding
- pods/resize
- deployments/scale
- replicasets/scale
- statefulsets/scale
- replicationcontrollers/scale
- services/proxy
- nodes/proxy
- services/status
There was a problem hiding this comment.
✔️ Updated the kubebuilder annotation in pkg/webhook/mutation.go with these values
deploy/gatekeeper.yaml
Outdated
There was a problem hiding this comment.
changes in deploy dir are overwritten with each release, so please remove any changes in gatekeeper.yaml file.
There was a problem hiding this comment.
Any changes in charts dir is overwritten in release, please remove any changes in this dir.
There was a problem hiding this comment.
Got it! Looks like these changes are applied in the manifest_staging dir when we run make generate.
There was a problem hiding this comment.
Yip! that is fine. We want these changes to manifest_staging. You can find out more on contributing to helm chart and overall here - https://open-policy-agent.github.io/gatekeeper/website/docs/help#contributing-to-helm-chart. Thanks again for the PR!
|
@ianstanton Thanks for the PR, few changes and we should be good. |
Signed-off-by: Ian Stanton <[email protected]>
What this PR does / why we need it:
Add
pod/resizesubresource to mutating and validating webhooks.Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when the PR gets merged):Fixes #3771
Special notes for your reviewer:
@JaydipGabani Please let me know if there's anything else we need for this one