-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add template for ServiceAccount annotations #239
Add template for ServiceAccount annotations #239
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello
- values schema should be adjusted and corresponding lint test cases added into
test/lint
. - helm unit tests should be added for affected template in
test/unit
.
aa56581
to
86d9308
Compare
I added a simple unit test for the serviceaccount annotations, but I'm less sure what to do about the values schema and linting you asked for. The only example of schema & linting I found was for the So, could you help me better understand what you would want to see for annotations schema and linting? |
Hello
You can use this as an example https://github.com/eshepelyuk/cmak-operator/blob/master/values.schema.json |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't forget to rebase and squash a PR into a single commit.
Signed-off-by: Chris Dueck <[email protected]>
6494cd3
to
fc46a71
Compare
I added a schema for the |
Thanks for the contribution https://github.com/open-policy-agent/kube-mgmt/actions/runs/6748036699 |
ServiceAccount annotations are needed to support web identity credentials: https://www.openpolicyagent.org/docs/latest/management-bundles/#web-identity-credentials