Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update actions/cache to v4.2.2 #2093

Merged
merged 1 commit into from
Mar 3, 2025

Conversation

mkannwischer
Copy link
Contributor

@mkannwischer mkannwischer commented Mar 3, 2025

image

Github recently turned off their old caching APIs: https://github.blog/changelog/2024-12-05-notice-of-upcoming-releases-and-breaking-changes-for-github-actions/#actions-cache-v1-v2-and-actions-toolkit-cache-package-closing-down.
liboqs' CI started failing with the following error message for me: This request has been automatically failed because it uses a deprecated version of actions/cache: e12d46a63a90f2fae62d114769bbf2a179198b5c. Please update your workflow to use v3/v4 of actions/cache to avoid interruptions.

This commit updates to the newer version of actions/cache that is using the new Github APIs.

Note that Github's blog post is misleading. A lot more versions than v1/v2 are being disabled including v3.3.3 that is used in liboqs - see actions/cache#1510

  • Does this PR change the input/output behaviour of a cryptographic algorithm (i.e., does it change known answer test values)? (If so, a version bump will be required from x.y.z to x.(y+1).0.)
  • Does this PR change the list of algorithms available -- either adding, removing, or renaming? Does this PR otherwise change an API? (If so, PRs in fully supported downstream projects dependent on these, i.e., oqs-provider will also need to be ready for review and merge by the time this is merged.)

@mkannwischer mkannwischer marked this pull request as ready for review March 3, 2025 09:03
@mkannwischer mkannwischer requested a review from SWilson4 as a code owner March 3, 2025 09:03
Github recently turned off their old caching APIs:
https://github.blog/changelog/2024-12-05-notice-of-upcoming-releases-and-breaking-changes-for-github-actions/#actions-cache-v1-v2-and-actions-toolkit-cache-package-closing-down

liboqs' CI started failing with the following error message for me:
This request has been automatically failed because it uses a deprecated version of `actions/cache: e12d46a63a90f2fae62d114769bbf2a179198b5c`. Please update your workflow to use v3/v4 of actions/cache to avoid interruptions.

This commit updates to the newer version of actions/cache that is using the
new Github APIs.

Note that Github's blog post is misleading. A lot more versions than v1/v2 are
being disabled including v3.3.3 that is used in liboqs - see
actions/cache#1510

Signed-off-by: Matthias J. Kannwischer <[email protected]>
Copy link
Member

@baentsch baentsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mkannwischer !

Copy link
Member

@bhess bhess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @mkannwischer !

@SWilson4 SWilson4 merged commit 5450d7c into open-quantum-safe:main Mar 3, 2025
78 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants