setting required property

open-solid · Nov 28, 2023 · eed2ece · eed2ece
1 parent 6955854
commit eed2ece
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 4 deletions.
diff --git a/src/OpenApi/Analyser/Guesser/Operation/OperationQueryParameterGuesser.php b/src/OpenApi/Analyser/Guesser/Operation/OperationQueryParameterGuesser.php
@@ -64,6 +64,7 @@ protected function guessRecursive(string $class, array &$parameters, Operation $
                     $parameter->name = $parent ? $parent.'[' : '';
                     $parameter->name .= $propertyReflector->getName();
                     $parameter->name .= $parent ? ']' : '';
+                    $parameter->parameter = $parameter->name;
                 }
 
                 if ($propertyReflector->isDefault()) {

diff --git a/tests/Functional/App/GetResourcesAction/Controller/GetResourcesPage.php b/tests/Functional/App/GetResourcesAction/Controller/GetResourcesPage.php
@@ -7,8 +7,8 @@
 class GetResourcesPage
 {
     #[Param]
-    public int $offset = 0;
+    public ?int $offset = 0;
 
     #[Param]
-    public int $limit = 10;
+    public ?int $limit = 10;
 }
diff --git a/tests/Functional/App/GetResourcesAction/Output/doc.json b/tests/Functional/App/GetResourcesAction/Output/doc.json
@@ -15,22 +15,24 @@
                 "operationId": "54dc66cace0345df01577de4f43a2910",
                 "parameters": [
                     {
+                        "parameter": "sort",
                         "name": "sort",
                         "in": "query"
                     },
                     {
+                        "parameter": "page[offset]",
                         "name": "page[offset]",
                         "in": "query",
-                        "required": true,
                         "example": 0
                     },
                     {
+                        "parameter": "page[limit]",
                         "name": "page[limit]",
                         "in": "query",
-                        "required": true,
                         "example": 10
                     },
                     {
+                        "parameter": "filter[name]",
                         "name": "filter[name]",
                         "in": "query"
                     }

diff --git a/tests/Functional/App/config.yaml b/tests/Functional/App/config.yaml
@@ -20,6 +20,7 @@ framework:
         cookie_samesite: lax
     php_errors:
         log: true
+        throw: true
 
 openapi:
     default_path: '%kernel.project_dir%/%kernel.test_case%/'