update schema to allow prestop sleep action in lifecycle hook #1517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://github.com/kubernetes/enhancements/blob/master/keps/sig-node/3960-pod-lifecycle-sleep-action/README.md In order to avoid network errors during deployments or pod interruptions, a pre stop sleep is often used to allow time for the async endpoint removal process to complete. Kubernetes supports doing the sleep natively now, removing the need for an exec based sleep command. The values schema for the chart was blocking the use of this feature.
dschaaff
requested review from
dmitryax,
TylerHelmuth,
povilasv and
a team
as code owners
The committers listed above are authorized under a signed CLA. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/kubernetes/enhancements/blob/master/keps/sig-node/3960-pod-lifecycle-sleep-action/README.md
In order to avoid network errors during deployments or pod interruptions, a pre stop sleep is often used to allow time for the async endpoint removal process to complete. Kubernetes supports doing the sleep natively now, removing the need for an exec based sleep command. The values schema for the chart was blocking the use of this feature.