-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add experimental otlp metrics exporter #1545
feat: add experimental otlp metrics exporter #1545
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @xuan-cao-swi! Awesome progress on this! Thanks for putting it together. I’m still testing some of the functionality and may have other feedback soon.
In the meantime, I have a structural concern I'd like to discuss with you and the other reviewers.
It seems like the opentelemetry-ruby project prefers to put experimental code into separate gems, like with metrics_api
and metrics_sdk
. With that in mind, I put the draft OTLP logs exporter in a separate gem.
My suggestion is to move the OTLP metrics exporter to a separate gem to keep experimental code separate from the code folks use in their production environments.
However, this is my current opinion, and the maintainers/approvers may have something else in mind. I hope this starts a discussion about the right path to take that can also apply to logs.
As you mentioned in the PR description, there's a ton of duplication in the logs OTLP exporter code. Eventually, I believe we will want to do a lot to DRY things up between the three signals, but at the moment, my gut tells me to keep signal exporters separate until they are stable.
exporter/otlp/lib/opentelemetry/exporter/otlp/metrics_exporter.rb
Outdated
Show resolved
Hide resolved
Co-authored-by: Kayla Reopelle (she/her) <[email protected]>
Hi @kaylareopelle, thanks for the suggestions, I totally agree that experimental code in separate gem, and combine them in the future if needed. I will create another PR. |
Closed, follow-up pr in #1551 |
Description
Added otlp metrics exporter that works with otlp collector through http protocol.
Most code copied from (trace) exporter (with test as well) with the assumption of same ssl, http etc. configuration. The major change is the proto decode. If the log exporter also use the similar configuration, having a utility file can help DRY.
Quick demo
Testing failed but it will success once the #1532 is merged.