-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: Support 3.1 Min Version #1802
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thinking about this a little more.... Unlike contrib, this repo has some gems with a 1.x release. I think we should mark this as a breaking change to avoid accidental upgrades for 3.0 users.
Unfortunately we don't have any post-install messages to warn folks, but I hope the contrib messages reached most users of these libraries.
What do you think about using #otel-ruby to announce this for the core libraries?
I want both the core and contrib libraries to be aligned with a min version, so I'd like to get this out relatively soon, while minimizing surprises.
@kaylareopelle I have changed the title and added a Users of Ruby 3.0 or older are not really impacted by it. They just won't be able to upgrade and will be pinned at an old version. This should not cause any conflicts for them. |
@arielvalentin, now that I look into it further, I agree. I've encountered complaints about increasing minimum Ruby versions before, but modern bundler versions should take It seems like this was finessed in the 1.11.x series of Bundler, though there are some improvements in 2.x. Since we set a minimum bundler version of 1.17.0 in the core libraries, I believe most of our users are safe. Maybe we should chat about this in the SIG to make sure everyone's on the same page. Breaking changes can be a big deal, so I don't want to force one unnecessarily. |
Ruby 3.0
status: eol
release date: 2020-12-25
normal maintenance until: 2023-04-01
EOL: 2024-04-23
https://www.ruby-lang.org/en/downloads/branches/