Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a derive crate to allow deriving conversions into common types #112

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Sufflope
Copy link

Moved from open-telemetry/opentelemetry-rust#1686

Changes

Implement derive macros to convert user types into common Key/Value related types.

See open-telemetry/opentelemetry-rust#1685

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

@Sufflope Sufflope requested a review from a team as a code owner September 30, 2024 14:27
@Sufflope Sufflope force-pushed the derive branch 4 times, most recently from 0eea130 to 2c7b8a2 Compare October 2, 2024 11:53
Copy link

codecov bot commented Oct 2, 2024

Codecov Report

Attention: Patch coverage is 98.79518% with 2 lines in your changes missing coverage. Please review.

Project coverage is 59.7%. Comparing base (56a6f45) to head (058a70f).
Report is 38 commits behind head on main.

Files with missing lines Patch % Lines
...emetry-derive/opentelemetry-derive-impl/src/lib.rs 98.1% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main    #112     +/-   ##
=======================================
+ Coverage   52.3%   59.7%   +7.4%     
=======================================
  Files         38      41      +3     
  Lines       4967    5940    +973     
=======================================
+ Hits        2598    3551    +953     
- Misses      2369    2389     +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Sufflope
Copy link
Author

Sufflope commented Oct 2, 2024

I changed the intra-doc links to common types to direct links to docs.rs to avoid adding the opentelemetry crate to dependencies, which would then be added to users' projects dependency tree in the workspace version, possibly another version than the one they use.

The two uncovered lines are weird false negatives, is it blocking?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants