Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix] Power manager now uses the last used profile_id to determine… #1

Merged
merged 1 commit into from
Dec 22, 2024

Conversation

jxqnzzj
Copy link
Contributor

@jxqnzzj jxqnzzj commented Dec 18, 2024

… the pm_action, instead of the first profile in the g_pm_cfg table.

Rootcause: For example, if the previous SPP profile request entered idle mode, the device will enter sniff mode after 1 second. However, if the peer device later requests entering active mode, the power manager will query g_pm_cfg to find the matching current action and get the AG's pm_action. This results in using the AG's idle timeout of 7 seconds. But at this point, we want the power manager to use the SPP profile's pm_action with a timeout of 1 second.

@CLAassistant
Copy link

CLAassistant commented Dec 18, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

@GUIDINGLI GUIDINGLI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Frozen935
Copy link
Contributor

aa

Copy link
Contributor

@gzh-terry gzh-terry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

N/A

@jxqnzzj jxqnzzj requested a review from gzh-terry December 18, 2024 07:59
Copy link
Contributor

@gzh-terry gzh-terry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test

Copy link
Contributor

@gzh-terry gzh-terry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test

@huangyulong3
Copy link

@openvela-robot

@hyson710 hyson710 added the bug Something isn't working label Dec 18, 2024
… the pm_action, instead of the first profile in the g_pm_cfg table.

bug: v/50506

Rootcause: For example, if the previous SPP profile request entered idle mode, the device will enter sniff mode after 1 second. However, if the peer device later requests entering active mode, the power manager will query `g_pm_cfg` to find the matching current action and get the AG's `pm_action`. This results in using the AG's idle timeout of 7 seconds. But at this point, we want the power manager to use the SPP profile's `pm_action` with a timeout of 1 second.

Signed-off-by: zhongzhijie1 <[email protected]>
@hyson710 hyson710 merged commit 6d5025d into open-vela:dev Dec 22, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants