bluetooth: Solving heap-buffer-overflow caused by memcpy. #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hyson710
reviewed
Jan 2, 2025
| @@ -74,7 +74,7 @@ typedef struct { | |||
| struct list_node node; | |||
| uint32_t cmd_code; | |||
| union { | |||
| uint8_t number[HFP_PHONENUM_DIGITS_MAX]; | |||
| char number[HFP_PHONENUM_DIGITS_MAX]; | |||
There was a problem hiding this comment.
please fix it in another patch:
HFP_PHONENUM_DIGITS_MAX + 1
and, please also check all other codes
jialu522
force-pushed
the
memcpydial
branch
2 times, most recently
from
c1052c4 to
e2b3c7a
Compare
hyson710
approved these changes
Jan 2, 2025
bug: v/49166 rootcause: The third parameter of memcpy is greater than the length of the source string, resulting in a heap-buffer-overflow error. Signed-off-by: jialu <[email protected]>
jxqnzzj
approved these changes
Jan 2, 2025
liuX10
approved these changes
Jan 2, 2025
jxqnzzj
approved these changes
Jan 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bug: v/49166
rootcause: The third parameter of memcpy is greater than the length of the source string, resulting in a heap-buffer-overflow error.