OS-Upgrade: Add a BT storage transformation tool. #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hyson710
approved these changes
Jan 2, 2025
bug: v/47945 Rootcause: Due to the differences in the storage format of Bluetooth information in different system versions, in order to ensure that saved information can continue to be used after system upgrades, the storage transformation tool has been added. Signed-off-by: chejinxian1 <[email protected]>
huangyulong3
reviewed
Jan 3, 2025
| uint32_t size; | ||
| uint32_t num; | ||
| SERVICE_REMOTE_BLE_DEVICE_S* devices; | ||
| } gap_ble_whitelist_data; |
There was a problem hiding this comment.
Why doesn't this structure type end in _t?
| syslog(LOG_DEBUG, "device type size is %zu", sizeof(SERVICE_REMOTE_BLE_DEVICE_S)); | ||
|
|
||
| whitelist_device = (SERVICE_REMOTE_BLE_DEVICE_S*)(&ble_whitelist->devices); // obtain the address of the first device | ||
| device_properties = (remote_device_le_properties_t*)malloc(sizeof(remote_device_le_properties_t) * ble_whitelist->num); |
There was a problem hiding this comment.
Here need to determine if ble_whitelist->num ! = 0 to call malloc otherwise there will be a crash.
| } | ||
|
|
||
| keys = (ble_keys_t*)(&bt_storage->bonded_devices); | ||
| device_properties = (remote_device_le_properties_t*)malloc(sizeof(remote_device_le_properties_t) * bt_storage->bonded_number); |
There was a problem hiding this comment.
Here need to determine if bt_storage->bonded_number ! = 0 to call malloc otherwise there will be a crash.
| syslog(LOG_DEBUG, "device type size is %zu", sizeof(SERVICE_REMOTE_DEVICE_S)); | ||
|
|
||
| device = (SERVICE_REMOTE_DEVICE_S*)(&bt_storage->bonded_devices); | ||
| device_properties = (remote_device_properties_t*)malloc(sizeof(remote_device_properties_t) * bt_storage->bonded_number); |
There was a problem hiding this comment.
Here need to determine if bt_storage->bonded_number ! = 0 to call malloc otherwise there will be a crash.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bug: v/47945
Rootcause: Due to the differences in the storage format of Bluetooth information in different system versions, in order to ensure that saved information can continue to be used after system upgrades, the storage transformation tool has been added.