LE Audio: le audio memory leak. #27
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
gzh-terry
approved these changes
Jan 3, 2025
hyson710
reviewed
Jan 4, 2025
| @@ -269,11 +269,15 @@ static void tbs_call_list_query_complete(tapi_async_result* result) | |||
| lea_tbs_call_state_t* state_s = malloc(sizeof(lea_tbs_call_state_t) * result->arg2); | |||
There was a problem hiding this comment.
Check NULL first, to avoid free(NULL)
hyson710
reviewed
Jan 4, 2025
|
|
||
| if (result->arg2 == 0) | ||
| if (result->arg2 == 0) { | ||
| free(state_s); |
There was a problem hiding this comment.
lea_tbs_call_state_changed() will not free state_s
better to add "free(state_s)" at the end of this func, add use "goto" to handle fault case
huangyulong3
force-pushed
the
github-bt
branch
from
9655bcf to
17b0add
Compare
bug: v/51552 Signed-off-by: huangyulong3 <[email protected]>
huangyulong3
force-pushed
the
github-bt
branch
from
17b0add to
ba0e6a9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LE Audio: le audio memory leak.
bug: v/51552
Signed-off-by: huangyulong3 [email protected]