bug fix: Make a new copy when you add a call to current_calls. #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bug: v/53473 rootcause: Adding the same pointer will cause repeated release. Signed-off-by: duqunbo <[email protected]>
hyson710
requested review from
chengkai15,
Frozen935,
jialu522,
zhangyuan376,
gzh-terry and
huangyulong3
gzh-terry
reviewed
Feb 14, 2025
| @@ -391,7 +391,7 @@ static void query_current_calls_final(hf_state_machine_t* hfsm) | |||
| hfp_current_call_t* ccall = bt_list_find(clist, call_index_cmp, &ucall->index); | |||
| /* update new call to current call list */ | |||
| if (!ccall) { | |||
| bt_list_add_tail(clist, ucall); | |||
| bt_list_add_tail(clist, hf_call_new(ucall->index, ucall->dir, ucall->state, ucall->mpty, ucall->number)); | |||
There was a problem hiding this comment.
Why do we create a new call rather than moving the existing one?
gzh-terry
approved these changes
Feb 14, 2025
zhangyuan376
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bug: v/53473
rootcause: Adding the same pointer will cause repeated release.
Summary
Make a new copy when you add a call to current_calls.