apps/nshlib: Using lib_get_tempbuffer() to save stack space
#65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Applications should not depend on any properties of nshlib Signed-off-by: chao an <[email protected]>
LINE_MAX: apache/nuttx#15344 Signed-off-by: wangjianyu3 <[email protected]>
Comparison
Config: "esp32s3-devkit:adb" with `CONFIG_LINE_MAX=512`
Test CMD: `ls | cat | cat | cat`
Without this patch
| | Before Test CMD | After Test CMD |
|---------------:|----------------:|----------------:|
| nsh_main.STACK | 0002624/0008096 | 0002624/0008096 |
| sh.STACK | 0003360/0004008 | 0003360/0004008 |
| Free/Total | 355288/403116 | 355288/403116 |
With this patch
| | Before Test CMD | After Test CMD |
|---------------:|----------------:|----------------:|
| nsh_main.STACK | 0001616/0008096 | 0001616/0008096 |
| sh.STACK | 0002352/0004008 | 0002352/0004008 |
| Free/Total | 355288/403116 | 354760/403116 |
Signed-off-by: wangjianyu3 <[email protected]>
…ails Signed-off-by: wangjianyu3 <[email protected]>
JianyuWang0623
requested review from
xiaoxiang781216 and
GUIDINGLI
as code owners
|
|
@anchao Could you take a look about the CLA please ;-) |
xiaoxiang781216
approved these changes
Jan 16, 2025
Coverity Log CID 1612743: (open-vela#1 of 1): Resource leak (RESOURCE_LEAK) 12. leaked_handle: The handle variable fd_out goes out of scope and leaks the handle. Signed-off-by: wangjianyu3 <[email protected]>
Done |
anchao
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Using
lib_get_tempbuffer()to save stack spacelib_get_tempbuffer()to save stack spaceCONFIG_NSH_LINELENtoLINE_MAXCONFIG_NSH_LINELENtoLINE_MAX(Picked from apps/system: replace CONFIG_NSH_LINELEN to LINE_MAX apache/nuttx-apps#2918 by @anchao )Impact
Testing
Config: "esp32s3-devkit:adb" with
CONFIG_LINE_MAX=512Test CMD:
ls | cat | cat | catWithout this patch
With this patch