net/udp: Let cansend return EWOULDBLOCK when send buffer is full #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Notes: 1. This commit do the same thing as TCP did: apache/nuttx#10627 2. UDP uses `iob_navail(false)` but TCP uses `iob_navail(true)`, this is because of a problem related to TCP recv window (apache/nuttx#4142), so we don't need to change UDP now. Signed-off-by: Zhe Weng <[email protected]>
xiaoxiang781216
approved these changes
Jan 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Notes:
iob_navail(false)but TCP usesiob_navail(true), this is because of a problem related to TCP recv window (tcp_send_buffered: throttle IOB allocations for send apache/nuttx#4142), so we don't need to change UDP now.Impact
UDP
Testing
SIM