Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

boards: Replace CONFIG_NSH_LINELEN with CONFIG_LINE_MAX #172

Open
wants to merge 6 commits into
base: dev
Choose a base branch
from

Conversation

JianyuWang0623
Copy link
Member

JianyuWang0623 and others added 6 commits January 16, 2025 21:24
The large max command line length may cause stack overflow.

Test
  ./tools/configure.sh lm3s6965-ek:qemu-flat
  make -j16
  qemu-system-arm -semihosting \
  		-M lm3s6965evb \
  		-device loader,file=nuttx.bin,addr=0x00000000 \
  		-netdev user,id=user0 \
  		-serial mon:stdio -nographic

Link: apache/nuttx-apps#2850
Signed-off-by: wangjianyu3 <[email protected]>
Details: apache/nuttx-apps#2943

1. find boards/ -name defconfig | xargs sed -i 's/CONFIG_NSH_LINELEN/CONFIG_LINE_MAX/g'
2. ./tools/refresh.sh --silent --defaults all

Signed-off-by: wangjianyu3 <[email protected]>
remove temporary emacs file added by accident

Signed-off-by: raiden00pl <[email protected]>
Log

  $ ./tools/refresh.sh --silent --defaults arch:risc-v
  Normalizing all boards in arch: risc-v !
    [1/227] Normalize arty_a7/nsh
    [2/227] Normalize arty_a7/netnsh
    [3/227] Normalize arty_a7/knsh
    # ... ...

Signed-off-by: wangjianyu3 <[email protected]>
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ JianyuWang0623
❌ raiden00pl
You have signed the CLA already but the status is still pending? Let us recheck it.

@JianyuWang0623
Copy link
Member Author

@raiden00pl Could you take a look about the CLA please ;-)

@JianyuWang0623 JianyuWang0623 marked this pull request as ready for review January 16, 2025 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants