Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Difference Between FIrst Public Review and Current #328

Draft
wants to merge 139 commits into
base: main
Choose a base branch
from
Draft

Difference Between FIrst Public Review and Current #328

wants to merge 139 commits into from

Conversation

JasonGlazer
Copy link
Collaborator

Do not merge this.

JasonGlazer and others added 30 commits November 3, 2023 12:12
@JasonGlazer
Remove from line 3813 unprintable character that was causing problems…
f26fcc0 
… with Python YAML reader on linux
@JacksonJ-KC
Set values for 'AppG B_RMDs Same'
4aafb14
@JacksonJ-KC
reinsert newline
172a4ed
@JasonGlazer
Merge branch 'develop' into fix_unprintable_character
078f97b
@JasonGlazer
Merge pull request #239 from open229/fix_unprintable_character
5f477f7 
Fix unprintable character
@JasonGlazer
Add informative note on the branches to the README.md
ab29903
@JasonGlazer
Merge pull request #240 from open229/add_branch_note
e95604a 
Add informative note on the branches to the README.md
@JasonGlazer
Improve connection diagrams created from jsonSchemaToDot and rename.
dc1f29e
@JasonGlazer
Merge pull request #241 from open229/ImproveConnectionDiagrams
0026858 
Improve connection diagrams created from jsonSchemaToDot and rename.
@JasonGlazer
Add blank RESOURCES.md page and link from README.md
b0c3d86
@JasonGlazer
Add content to the RESOURCES.md file, mostly links.
033a789
@JasonGlazer
Merge pull request #244 from open229/Add_rmd_gen_resources
0e6fd34 
Add RMD generation resources
@JasonGlazer
Fix broken link, typo and text related to the resources page on the R…
2063bfd 
…EADME.md
@JasonGlazer
Merge pull request #245 from open229/fixReourcesBrokenLink
0f31886 
Fix broken link, typo and text related to the resources page on the readme
@JasonGlazer
Add chicago demo RMD files
0967157
@JasonGlazer
Change RMD to RPD
c3d7882
@JasonGlazer
Update README.md to be more accurate and use the right terms for the …
56ecf3e 
…various schemas
@JasonGlazer
Add system type examples
7fdf8f6
@JasonGlazer
Merge pull request #251 from open229/more_resources
c54dc6a 
Add more resources and update to RPD in the readme
@JasonGlazer
Fix name and link
945d4a3
@JasonGlazer
Fix typo
e1b2ea3
@JasonGlazer
Merge pull request #253 from open229/fix_createRPD_link
eef7ded 
Fix resources page for createRPD
@JasonGlazer
Increment version number to 0.0.37
a0a3feb
@JasonGlazer
Add notes to heating system heat pump and auxiliary temperature opera…
134cda0 
…tion for issue #211
@JasonGlazer
Add notes to Chiller for COPs to address #226
9df6576
@JasonGlazer
Fix typo in EnergyRecoveryOptions for #228
677b8e4
@JasonGlazer
Fix to use maximum in Terminal to address #233
af31ebb
@JasonGlazer
Add new options to PumpSpeedControlOptions to address #235
8bd46a5
@JasonGlazer
Expands on note for fluid_loops to address #242
440d092
@JasonGlazer
Clarify description and add note for service_water_piping for #243
cf564e4
@JasonGlazer
Merge pull request #307 from open229/update-0.1.2
52ced1e 
Update 0.1.2
@JasonGlazer
Merge pull request #290 from open229/jjarboe-rpd-gen-test-answers
65412cf 
Add correct answer RPD files
@JasonGlazer
Merge branch 'develop' into jjarboe-sort-enumerations
a53544f
@JasonGlazer
Add sorted enumerations for docs229
4507433
@JasonGlazer
Merge pull request #289 from open229/jjarboe-sort-enumerations
6743b3e 
sort enumerations in markdown
@JasonGlazer
Merge pull request #288 from open229/jjarboe-rpd-gen-test-schema
2f38fbf 
create rpd generation software test report schema yaml
@JasonGlazer
Use -999 for ignored hours in hourly_X_design_year schedules based on…
e38092d 
… Schema WG discussion
@JasonGlazer
Update the README.md describing all schemas to address #309
5b22c1e
@JasonGlazer
Update docs229
63396bd
@JasonGlazer
Merge pull request #310 from open229/update-0.1.2-additional
d192f25 
Update 0.1.2 additional
@JasonGlazer
Update version number to 0.1.3
8dc6c51
@JasonGlazer
Remove lower limit and add note for oversizing_factor in response to #…
f20be09 
…311
@JasonGlazer
Remove Construction.surface_construction_input_option and clarify in …
72e15f1 
…notes to address #312
@JasonGlazer
Remove IN_ZONE from ComponentLocationOptions and clarify notes to res…
03c1997 
…olve #314
@JasonGlazer
Removed unnecessary required elements in Output2019ASHRAE901.schema.y…
6fc0519 
…aml to address #315
@JasonGlazer
Add to surface.adjacent_zone note to indicate no duplication interior…
178d4f1 
… surfaces are needed to address #316
@JasonGlazer
Changed ServiceWaterHeatingDistributionSystem.service_water_piping to…
ebea6a0 
… be a single instance rather than a list to address #318
@JasonGlazer
Fix ServiceWaterHeaterTankOptions typo to address #319
45689ba
@JasonGlazer
Added notes and an additional efficiency metric option for chillers r…
e1e9894 
…elated to rated vs design to address #317
@JasonGlazer
Add ChillerFunctionOptions describing cold/hot/both water made to add…
a51104f 
…ress #313
@JasonGlazer
Allow references for Constructions and Materials so they don't need t…
965f626 
…o be repeated. Addresses #231
@JasonGlazer
Add service_water_heating_uses to BuildingSegment and allow child or …
0b26719 
…reference to address #264
@JasonGlazer
Add notes to service_water_heating_uses to help explain child or refe…
a79ba19 
…rence
@JasonGlazer
Further clarification of ChillerEfficiencyMetricOptions notes.
4476f60
@JasonGlazer
Add metadata group from Standard 232 for #308
2826494
@JasonGlazer
Restructure output to reduce redundancy per #217
ec8bf65
@JasonGlazer
Update notes for non_mechanical_cooling_fans for high ACH warehouse a…
5f000c8 
…pplications for #320
@JasonGlazer
Moved data elements for calendar and weather from RulesetProjectDescr…
651e606 
…iption to RulesetModelDescription to resolve #248
@JasonGlazer
Fix double line notes for creating dot files. Add docs229 files.
ef138b0
@JasonGlazer
Merge pull request #322 from open229/update-0.1.3
6509fdc 
Update 0.1.3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JasonGlazer @JacksonJ-KC