Support all property types & architechture rework #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nilsRoettgerAtBB
requested changes
Feb 26, 2024
app/ref_app.cpp
Outdated
| // Start streaming openDAQ OpcUa server | ||
| instance.addServer("openDAQ OpcUa", nullptr); | ||
|
|
||
| auto device = instance.getRootDevice(); | ||
|
|
||
| JetServer myJet = JetServer(device); |
There was a problem hiding this comment.
Why do we not use instance.addServer("jet", nullptr) and then it starts running.
There was a problem hiding this comment.
Because JetModule is not an openDAQ module. This is a separate library which mimics an openDAQ module. We have to align whether we want JetModule within openDAQ or we are going to keep to as a separate library.
include/jet_server.h
Outdated
There was a problem hiding this comment.
We had a reivew session and we conclude the feedback on this confluence page: https://blueberrydaq.atlassian.net/wiki/spaces/B/pages/460685326/501-3-6+Jet+Module
nilsRoettgerAtBB
approved these changes
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces following changes: