Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Content Length Writer #652

Merged
merged 1 commit into from
Aug 16, 2024
Merged

Fix Content Length Writer #652

merged 1 commit into from
Aug 16, 2024

Conversation

mpass99
Copy link
Contributor

@mpass99 mpass99 commented Aug 16, 2024

  • The Content-Length-Header did not get removed in the error handling
  • The Content-Length Writer fired the HTTP Headers unnecessarily early impeding sending of an error message.

Closes #595

@mpass99 mpass99 requested a review from MrSerth August 16, 2024 16:02
@mpass99 mpass99 self-assigned this Aug 16, 2024
that sends the HTTP Headers even if no data has to be written.
@mpass99 mpass99 force-pushed the fix/#595-wrong-content-length branch from bab9716 to 6c298b4 Compare August 16, 2024 16:14
Copy link
Member

@MrSerth MrSerth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good and fixes the actual problem (I reproduced it first with CodeOcean locally and then upgraded Poseidon to see that it got resolved) 👍

Copy link

codecov bot commented Aug 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.73%. Comparing base (06deab0) to head (6c298b4).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #652      +/-   ##
==========================================
+ Coverage   76.63%   76.73%   +0.10%     
==========================================
  Files          41       41              
  Lines        3509     3512       +3     
==========================================
+ Hits         2689     2695       +6     
+ Misses        608      605       -3     
  Partials      212      212              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mpass99 mpass99 merged commit 7efee3d into main Aug 16, 2024
12 checks passed
@mpass99 mpass99 deleted the fix/#595-wrong-content-length branch August 16, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Could not write JSON response
2 participants