-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix missing link target #662
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #662 +/- ##
==========================================
+ Coverage 76.20% 76.38% +0.18%
==========================================
Files 43 43
Lines 3551 3557 +6
==========================================
+ Hits 2706 2717 +11
+ Misses 620 617 -3
+ Partials 225 223 -2 ☔ View full report in Codecov by Sentry. |
5758a0e
to
64229ed
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks good! I tested the branch locally and can confirm that your patch resolves the issue for me.
There is one question left, though: When listing files where this (former) bug triggers, I still have an exit code 1 and thus the following warning: level=warning msg="Ignoring error of listing the file system" error="<nil>" exitCode=1 package=runner
. Do we just continue to ignore it (and log as warning) or do we want to do something special (since we know why the error was generated in the first place....)
64229ed
to
3be6d03
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect, works like a charm. Thanks!
3be6d03
to
2318ca2
Compare
for listing the file system with a link, the executing user has not enough privileges to read the target.
2318ca2
to
14a7205
Compare
I've created an issue for the flaky unit test #669. |
I've also amended ticket #623 for the failed e2e test. It seems like we need to investigate in the test suite, once again. |
for listing the file system with a link, the executing user does not have enough privileges to read the target.
Closes #596