Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow up, Fix Integer Overflow #666

Merged
merged 1 commit into from
Sep 2, 2024
Merged

Follow up, Fix Integer Overflow #666

merged 1 commit into from
Sep 2, 2024

Conversation

mpass99
Copy link
Contributor

@mpass99 mpass99 commented Sep 2, 2024

The new minor update of Golangcilint, from v1.60.2 to v1.60.3 enabled the identification of another theoretical Integer Overflow Vulnerability.

Related to #664

that were identified by the new GolangCILint subversion v1.60.3.
@mpass99 mpass99 requested a review from MrSerth September 2, 2024 13:14
@mpass99 mpass99 self-assigned this Sep 2, 2024
Copy link

codecov bot commented Sep 2, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 76.20%. Comparing base (d448dd8) to head (191f657).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/runner/nomad_runner.go 33.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #666      +/-   ##
==========================================
- Coverage   76.24%   76.20%   -0.05%     
==========================================
  Files          43       43              
  Lines        3549     3551       +2     
==========================================
  Hits         2706     2706              
- Misses        619      620       +1     
- Partials      224      225       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MrSerth MrSerth merged commit 35bbae7 into main Sep 2, 2024
11 of 12 checks passed
@MrSerth MrSerth deleted the fix/linting-issues branch September 2, 2024 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants