Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HLS Video Downloads #299

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

HLS Video Downloads #299

wants to merge 15 commits into from

Conversation

bengelhaupt
Copy link
Contributor

@bengelhaupt bengelhaupt commented Jan 3, 2021

This is a first draft of the HLS video downloading and playback feature.

Main changes:

  • HLS video streams can be downloaded with subtitles embedded
  • Downloaded HLS streams can be played
  • The default download quality can be selected in settings
  • MP4 downloading functionality has been completely removed; MP4 streams are only fallback for online playback
  • Interfaces and behavior of file and video download have been generalized and unified (notifications etc.)
  • SD card support remains, but storage migration (moving data between internal storage and sdcard) had to be removed because it is not compatible with the way ExoPlayer stores the video data
  • Many under-the-hood changes for download handling (Downloads are now always handled through their respective Downloaders. That e.g. means that a file download must not be removed manually by simply deleting the file. Our Download UI takes care of that.)

TODOs:

  • HLS video size estimation (no video size is available)
  • HLS casting (excluded from requirements)
  • Dialog with hint on first download, that the video quality can be changed in settings
  • documentation
  • unit + instrumented tests
  • testing on physical devices
  • how to migrate existing downloads?
  • Seek preview does not work for downloaded HLS streams

Fixes #212

@bengelhaupt bengelhaupt added the feature 📦 A new or adjusted user-facing feature. label Jan 3, 2021
@bengelhaupt bengelhaupt added this to the Migrate Videos to HLS milestone Jan 3, 2021
@bengelhaupt bengelhaupt self-assigned this Jan 3, 2021
@bengelhaupt bengelhaupt force-pushed the be/hls branch 2 times, most recently from 8b04b13 to f3a73ea Compare July 18, 2021 21:09
@bengelhaupt bengelhaupt marked this pull request as ready for review July 18, 2021 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature 📦 A new or adjusted user-facing feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HLS Video Downloads
1 participant