-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HLS Video Downloads #299
Open
bengelhaupt
wants to merge
15
commits into
master
Choose a base branch
from
be/hls
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
HLS Video Downloads #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bengelhaupt
force-pushed
the
be/hls
branch
2 times, most recently
from
January 14, 2021 19:11
103ae41
to
ab5f29e
Compare
...de/xikolo/testing/instrumented/unit/download/filedownload/AbstractFileDownloadHandlerTest.kt
Show resolved
Hide resolved
...va/de/xikolo/testing/instrumented/unit/download/filedownload/AbstractFileDownloadItemTest.kt
Show resolved
Hide resolved
bengelhaupt
force-pushed
the
be/hls
branch
2 times, most recently
from
July 18, 2021 21:09
8b04b13
to
f3a73ea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first draft of the HLS video downloading and playback feature.
Main changes:
TODOs:
HLS video size estimation (no video size is available)HLS casting(excluded from requirements)Dialog with hint on first download, that the video quality can be changed in settingsdocumentationunit + instrumented teststesting on physical devicesFixes #212