Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update fixable dependencies #2229

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sinh117801
Copy link

Description

This change is only update dependencies that automatically update by run npm audit --fix

Related issues and discussion

#{Issue Number}

Screenshots, if any

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • If you have multiple commits please combine them into one commit by squashing them.

  • Read and understood the contribution guidelines at web-app/.github/CONTRIBUTING.md.

@IOhacker
Copy link
Contributor

Seems that the commit is missing another files, not only the lock file

@sinh117801
Copy link
Author

sinh117801 commented Dec 25, 2024

Hi @IOhacker I'm not sure which file you're referring to, but normally when we run npm audit fix, it modifies the package-lock.json file.

@IOhacker
Copy link
Contributor

IOhacker commented Dec 25, 2024 via email

@sinh117801
Copy link
Author

@IOhacker - Yes, there are no changes in package.json. The functionality is working as expected - I ran docker-compose to build the app, and it's also working correctly.

@PC-11-00
Copy link
Collaborator

@sinh117801 : it is not possible that package-lock.json changed and package.json didn't change.

@sinh117801
Copy link
Author

sinh117801 commented Dec 27, 2024

@PC-11-00 - it is possible, because it is run npm audit fix is not work the same as npm update. If you review the change file, all change are peer dependencies, not dependencies in package.json. So it has nothing change in package.json.

@PC-11-00
Copy link
Collaborator

PC-11-00 commented Jan 3, 2025

@sinh117801 you are correct!

@PC-11-00
Copy link
Collaborator

PC-11-00 commented Jan 3, 2025

Did you do dev_testing?
Everything was working fine?

@sinh117801
Copy link
Author

Do you mean run npm run test? It seems like it fails. But for running npm run serve:dev, it works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants