-
Notifications
You must be signed in to change notification settings - Fork 561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update fixable dependencies #2229
base: master
Are you sure you want to change the base?
Conversation
Seems that the commit is missing another files, not only the lock file |
Hi @IOhacker I'm not sure which file you're referring to, but normally when we run npm audit fix, it modifies the package-lock.json file. |
What about the package.json? Have you tested the web app functionalities
after the update?
El mié., 25 de diciembre de 2024 2:09 a. m., Sinh ***@***.***>
escribió:
… Hi @IOhacker <https://github.com/IOhacker> I'm not sure which file you're
referring to, but normally when we run npm audit fix, it modifies the
package-lock.json file.
—
Reply to this email directly, view it on GitHub
<#2229 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALD2ZATA7SJXGTS5YXAB2TL2HJR2DAVCNFSM6AAAAABUENOXKSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNRRG4YDENRYGA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
@IOhacker - Yes, there are no changes in package.json. The functionality is working as expected - I ran docker-compose to build the app, and it's also working correctly. |
@sinh117801 : it is not possible that package-lock.json changed and package.json didn't change. |
@PC-11-00 - it is possible, because it is run |
@sinh117801 you are correct! |
Did you do dev_testing? |
Do you mean run |
Description
This change is only update dependencies that automatically update by run
npm audit --fix
Related issues and discussion
#{Issue Number}
Screenshots, if any
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
If you have multiple commits please combine them into one commit by squashing them.
Read and understood the contribution guidelines at
web-app/.github/CONTRIBUTING.md
.