Migrate from setup.py to pyproject #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cryptomilk
force-pushed
the
asn-pyproject
branch
from
d7fd863 to
659d901
Compare
|
@dmulder do you prefer setuptools or pdm? |
I've never even heard of pdm. I have no preference. |
|
There is one issue I still haven't found out how to fix: I don't see how to do that, you can't seem to provide a destination to all files. |
cryptomilk
force-pushed
the
asn-pyproject
branch
2 times, most recently
from
ed83762 to
bd27b11
Compare
cryptomilk
force-pushed
the
asn-pyproject
branch
from
bd27b11 to
2bdb0dd
Compare
cryptomilk
force-pushed
the
asn-pyproject
branch
from
7487843 to
298a88c
Compare
cryptomilk
force-pushed
the
asn-pyproject
branch
from
298a88c to
c4ebc71
Compare
|
I got it sorted out. I also added a tox.ini filed and use gh-actions for running tox now. |
cryptomilk
changed the title
|
Check the tests output, it runs test for several python versions now. |
|
We could also enable linting and type checking if you want. |
|
@cryptomilk I granted you write access to the repo, so feel free to merge when ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate from setup.py to pyproject.toml