Update __init__.py #193
Closed
Update __init__.py #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danigm
requested changes
Apr 15, 2024
There was a problem hiding this comment.
Please, use a better description in the commit text, "update init.py" is not descriptive enough.
About the code change, yes, this is needed right now because in other case the show and fetch subcommands will fail. The local and localfile arguments are added just for the generate subcommand. Maybe we can also add these new arguments to all the subcommands that uses the fetch_data.
But in any case, we can merge this once the commit message is something more descriptive. The comment at line 397 should be the commit message and can be removed from the code.
| @@ -394,8 +394,13 @@ def generate(args): | |||
|
|
|||
|
|
|||
| def fetch_data(args): | |||
| localfile = args.localfile | |||
| local = args.local | |||
| #fix bug: AttributeError: 'Namespace' object has no attribute 'localfile' for fetch command | |||
There was a problem hiding this comment.
Please, use this as commit message and remove from here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.