Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Avoid dynamic properties not allowed error and include 8.2 in CI #113

Merged
merged 6 commits into from
Aug 8, 2024
Merged

fix: Avoid dynamic properties not allowed error and include 8.2 in CI #113

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
8addfea
[SB-3744] No dynamic properties
elias-playfinder Oct 5, 2023
725a6bd
Update CI to run for all versions even if one fails
nickevansuk Aug 7, 2024
5983e15
Update InstanceValidator.php to use "protected" keyword
nickevansuk Aug 7, 2024
cbc749c
Include 8.2 in CI
nickevansuk Aug 7, 2024
19d64c3
Update to protected
nickevansuk Aug 7, 2024
6c0e417
Update to protected
nickevansuk Aug 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/tests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,9 @@ jobs:
test:
runs-on: ubuntu-latest
strategy:
fail-fast: false
matrix:
php-versions: ['5.6', '7.3', '7.4', '8.0']
php-versions: ['5.6', '7.3', '7.4', '8.0', '8.2']
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not for this, but I'd really like to discuss removing support for 5.6, it's been EOL for over 5 years now https://www.php.net/eol.php

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think Our Parks are still using it... need to confirm that though

name: PHP ${{ matrix.php-versions }}
steps:
- name: Checkout
Expand Down
7 changes: 6 additions & 1 deletion src/Validators/EnumValidator.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,11 @@

class EnumValidator extends BaseValidator
{
/**
* @var string
*/
protected $classname;

public function __construct($classname)
{
$this->classname = $classname;
Expand All @@ -17,7 +22,7 @@ public function __construct($classname)
* It is therefore recommended to call the "run" method first before this.
*
* @param mixed $value The value to coerce.
* @return int The coerced value
* @return mixed The coerced value
*/
public function coerce($value)
{
Expand Down
5 changes: 5 additions & 0 deletions src/Validators/InstanceValidator.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,11 @@

class InstanceValidator extends BaseValidator
{
/**
* @var string
*/
protected $classname;

public function __construct($classname)
{
$this->classname = $classname;
Expand Down
5 changes: 5 additions & 0 deletions src/Validators/RpdeEnumValidator.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,11 @@

class RpdeEnumValidator extends BaseValidator
{
/**
* @var string
*/
protected $classname;

public function __construct($classname)
{
$this->classname = $classname;
Expand Down
Loading