Added checks for wav recorder state to ensure they stay in sync #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
In the manual PTT mode it is possible for the button to get into an incorrect state, throwing an error on the page.
Added checks for ensuring the wav recorder state and the page state are in sync. Calling .record() when already recording and .pause() while already paused causes errors.
Reproduction:
The error is reproducible if the user moves their mouse cursor off the manual PTT button after pressing it (Mouse Down over button -> move mouse off of button -> release mouse, the screen will stay recording). Clicking the button again will cause an error as the wav recorder is still recording from before.
Fix:
Check the state before calling operations on the wav recorder.