-
-
Notifications
You must be signed in to change notification settings - Fork 488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(openapi-react-query): support for useInfiniteQuery() #1881
base: main
Are you sure you want to change the base?
Conversation
|
Is there any reason not to introduce this? |
@tommymarshall @jungwoo3490 this pull request does not seem to be ready to be merged as tests are still failing. And with the latest changes it now has conflicts with main branch. I would be happy to review a pull request introducing those changes with successful tests and resolved conflicts. |
Looks like it it's a build error with existing code -- worth re-running or getting the branch up-to-date @jungwoo3490 ? |
@kerwanp @tommymarshall |
Thank you for helping out @jungwoo3490! |
da3a024
to
5b61eea
Compare
@kerwanp @drwpow @tommymarshall |
I am confused, how do you use the |
When will be released? Any news? |
{ | ||
...baseOptions, | ||
initialPageParam: 0, | ||
getNextPageParam: (lastPage: any, allPages: any[], lastPageParam: number, allPageParams: number[]) => |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to add getPreviousPageParam
here too or do we get it by default via baseOptions
?
Any update on this? It's needed for cursor pagination in my application & I was surprised to not see it on the created query client. Love what y'all have doen with openapi-ts btw, coming from ts-rest |
Hi all, this hook is part of the core tanstack query and is one of the main reasons why devs choose tanstack query as opposed to other libs, I see a lot of work has been done already (Many thanks for them!) but we're wondering if we can help in anyway to have this merged? I, for one, would be very happy to help. Thanks. |
Changes
close #1828
I added
useInfiniteQuery()
toopenapi-react-query
.How to Review
Any feedback is welcome. I'll review it and make updates!
Checklist
docs/
updated (if necessary)pnpm run update:examples
run (only applicable for openapi-typescript)