Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(openapi-typescript): generate path params flag #2102

Merged
merged 1 commit into from
Jan 25, 2025

Conversation

ViktorPontinen
Copy link
Contributor

@ViktorPontinen ViktorPontinen commented Jan 17, 2025

Changes

What does this PR change? Link to any related issue(s).
#2103

How to Review

Use openapi-typescript to convert a schema that has missing path paramaters definitions.
How can a reviewer review your changes? What should be kept in mind for this review?

Checklist

  • Unit tests updated
  • docs/ updated (if necessary)
  • pnpm run update:examples run (only applicable for openapi-typescript)

Copy link

netlify bot commented Jan 17, 2025

👷 Deploy request for openapi-ts pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 9d22133

Copy link

changeset-bot bot commented Jan 17, 2025

🦋 Changeset detected

Latest commit: 9d22133

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
openapi-typescript Minor
swr-openapi Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ViktorPontinen ViktorPontinen force-pushed the feat/generate-path-params branch from 9f2ea32 to 113d340 Compare January 17, 2025 11:10
@ViktorPontinen ViktorPontinen force-pushed the feat/generate-path-params branch from 113d340 to 0afeb62 Compare January 17, 2025 11:12
@ViktorPontinen ViktorPontinen marked this pull request as ready for review January 17, 2025 11:14
@ViktorPontinen ViktorPontinen requested a review from a team as a code owner January 17, 2025 11:14
@ViktorPontinen ViktorPontinen force-pushed the feat/generate-path-params branch from 0afeb62 to 9d22133 Compare January 17, 2025 11:15
@ViktorPontinen ViktorPontinen changed the title feat(open-api-typescript): generate path params flag feat(openapi-typescript): generate path params flag Jan 17, 2025
Copy link
Contributor

@drwpow drwpow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thank you! I see how this could be useful. Great implementation, and great tests! I don’t have any feedback.

@drwpow drwpow merged commit 0cdfc47 into openapi-ts:main Jan 25, 2025
8 checks passed
@openapi-ts-bot openapi-ts-bot mentioned this pull request Jan 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants