Bugfixes and improvements for openaps-menu. #21
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes crash when actual number of BGs in monitor/glucose.json is fewer than the number we want to display (72 or 120). Thanks to @mhaeberli for catching & patching! Also fixes graph offset so we have a continuous line of BGs.
Prevent newline (#14)
Fix for low number of BGs and offset
upgrade jon-dev with node pi buttons
fixes and improvements
Revert "upgrade jon-dev with node pi buttons"
This should help keep openaps-menu from crashing when the screen is broken.
bugfixes and add preferences toggle for status display
more preferences, update big_bg_status.js
|
These commits should probably be squashed... |
Bryan merged upstream bugfixes...
index.js
Outdated
| @@ -35,7 +36,7 @@ var voltage = require('./lib/voltage/voltage')(voltageConfig) | |||
| var batteryConfig = require('./config/battery.json') | |||
| var socketServer = require('./lib/socket-server/socket-server')({ | |||
| voltage: voltage, | |||
| battery: batteryConfig | |||
| battery: batteryConfig, | |||
There was a problem hiding this comment.
It was working for me, but I think I added something below that at some point and forgot to remove the comma. Thanks.
|
I still vote for an 8pm-8am night mode for OLED inversion, but that’s a feature request, not something we have to do in this PR. |
|
(Superceded by #22 ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Requires merge of openaps/oref0#1130)
"status_screen": "bigbgstatus"into~/myopenaps/preferences.json"status_screen": "off"in~/myopenaps/preferences.json"wearOLEDevenly": "off"in~/myopenaps/preferences.json. Added 8pm-8am inversion mode too (more lit pixels during the day, fewer at night), which can be set with"wearOLEDevenly": "nightandday"in~/myopenaps/preferences.json.