Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config.misc.pluginlist.fc_bookmarks_order #3328

Merged
merged 1 commit into from
Jan 4, 2025
Merged

config.misc.pluginlist.fc_bookmarks_order #3328

merged 1 commit into from
Jan 4, 2025

Conversation

GhostofGeeeee
Copy link
Contributor

@GhostofGeeeee GhostofGeeeee commented May 17, 2024 •
edited
Loading

couldn't handle bookmarks with "," in path.

Don't use .split(",") and ",".join() to use ConfigText as list.
Use list as string for ConfigText.

@GhostofGeeeee
Copy link
Contributor Author

GhostofGeeeee commented Jan 2, 2025 •
edited
Loading

Is this a alternative to fix and close it?
GhostofGeeeee@b99b657

@jbleyel
Copy link
Contributor

jbleyel commented Jan 2, 2025

This is on my todo list, please wait.

@GhostofGeeeee GhostofGeeeee force-pushed the fc_bookmarks_order branch 3 times, most recently from 6690825 to 437749a Compare January 3, 2025 15:53
@GhostofGeeeee
Copy link
Contributor Author

Thank you for feedback, now it looks better.

@GhostofGeeeee GhostofGeeeee marked this pull request as ready for review January 3, 2025 15:54
@jbleyel
Copy link
Contributor

jbleyel commented Jan 4, 2025 •
edited
Loading

Sorry. This migration is too complicated.
Just rename the 3 settings and you are done.

Please use camel case and no underlines for the new name.

@GhostofGeeeee GhostofGeeeee deleted the fc_bookmarks_order branch January 4, 2025 10:52
@GhostofGeeeee
Copy link
Contributor Author

GhostofGeeeee commented Jan 4, 2025 •
edited
Loading

Ooops now I closed(branch deleted) it.
Now i have this.
(f892a87)
I think you mean Migration ist to complicated.
(1f83e4b)

@GhostofGeeeee GhostofGeeeee restored the fc_bookmarks_order branch January 4, 2025 11:16
@jbleyel
Copy link
Contributor

jbleyel commented Jan 4, 2025

Please rename the configs to:

config.misc.pluginlist.eventinfoOrder = ConfigText(default="[]")
config.misc.pluginlist.extensionOrder = ConfigText(default="[]")
config.misc.pluginlist.fcBookmarksOrder = ConfigText(default=f"['{_("Storage Devices")}']")

and then revert all changes in Migration.py.
Because you do not need any migration if the configs are new.

@GhostofGeeeee GhostofGeeeee reopened this Jan 4, 2025
@GhostofGeeeee
Copy link
Contributor Author

Done

jbleyel
jbleyel reviewed Jan 4, 2025
View reviewed changes
lib/python/Plugins/Extensions/FileCommander/plugin.py Outdated
@@ -1010,7 +1010,7 @@ def makeSymlinkCallback(newName):

def keyManageBookmarks(self, current):
bookmarks = config.plugins.FileCommander.bookmarks.value
order = config.misc.pluginlist.fc_bookmarks_order.value.split(",")
order = eval(config.misc.pluginlist.fcBookmarksOrder_order.value)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo

@jbleyel
Copy link
Contributor

jbleyel commented Jan 4, 2025

Bis auf den einen Typo sieht es gut aus.

Jetzt musst du das natürlich noch testen.
Vor allem mit jeglichen Sonderzeichen im Name vom Verzeichnis.

@GhostofGeeeee
config.misc.pluginlist.fc_bookmarks_order
78c739a 
couldn't handle bookmarks with "," in path.

Don't use .split(",") and ",".join() to use ConfigText as list.
Use list as string for ConfigText.
@GhostofGeeeee
Copy link
Contributor Author

OMG der Typo! Danke!
Ich hab einen Ordner erstellt mit allen Sonderzeichen(~30) die die virtuelle Tastatur hergibt.
Funktioniert.

@jbleyel jbleyel merged commit d56712f into openatv:master Jan 4, 2025
1 of 2 checks passed
@GhostofGeeeee GhostofGeeeee deleted the fc_bookmarks_order branch January 4, 2025 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbleyel jbleyel jbleyel left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GhostofGeeeee @jbleyel