Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release 8] Fix paella player playback bar + introducing Video qualities in player settings #397

Open
wants to merge 1 commit into
base: release_8
Choose a base branch
from

Conversation

ferishili
Copy link
Contributor

This PR fixes 2 Issues:

Description

The paella playback bar does not hide automatically when any of the player settings/features is used: #387 (comment)
The paella player does not support multi quality videos: #383 (comment)

Solution

The changes include upgrading paella plugins/core libraries such as paella-core & paella-slide-plugins
as well as introducing new plugin paella-mp4multiquality-plugin with its implementation/addition to the player js!

To TEST

  • Patch this PR
  • Hard reload the browser you are testing with (since changes are solely on js and we need to remove/refresh the cache)
  • Make sure the playback bar gets vanished after opening any player setting while the video is in playing state!
  • Make sure to also use a video with different qualities (for example videos created via Studio provide 3 different qualities by default)
  • Make sure you can select different qualities via the playback bar settings item "Video Quality"

… upgrade

fixes opencast-ilias#383: support multi-quality via new paella plugin
@ferishili ferishili added bug Something isn't working enhancement New feature or request labels Jan 20, 2025
@ferishili ferishili self-assigned this Jan 20, 2025
@snoesberger
Copy link

Thanks @ferishili! The multi-quality plugin works, I can now switch between different video qualities and the playbar now hides correctly after the configured amount of time.

From my point of view, this PR is ready to merge.

@dagraf
Copy link

dagraf commented Jan 22, 2025

@chfsx Since tests from @snoesberger were successfull, can you please review this PR and merge it if everything is fine or comment it, if otherwise? Thx!

@dagraf dagraf requested a review from chfsx January 22, 2025 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
Status: Testing
Development

Successfully merging this pull request may close these issues.

3 participants