Docker #10
Merged
Docker #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/cloudcasting_app/app.py
dfulu
approved these changes
Feb 4, 2025
dfulu
reviewed
Feb 4, 2025
| out_dir = os.environ["OUTPUT_PREDICTION_DIRECTORY"] | ||
|
|
||
| latest_zarr_path = f"{out_dir}/latest.zarr" | ||
| t0_string_zarr_path = t0.strftime(f"{out_dir}/%Y-%m-%dT%H:%M.zarr") | ||
|
|
||
| fs, _ = fsspec.core.url_to_fs(out_dir) | ||
| fs = fsspec.open(out_dir).fs |
There was a problem hiding this comment.
Did this change solve something? I thought the old one was cleaner
There was a problem hiding this comment.
Yea, for some reason that didn't work. Perhaps something to check in the future. It might have done, i just mvoed it back to something i know it definately works
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
How Has This Been Tested?
ran in AWS and it worked
Yes
Checklist: