Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Docs on which ML models take which as inputs #213

Closed
wants to merge 0 commits into from

Conversation

utsav-pal
Copy link
Contributor

this PR update the README file only

This pull request addresses issue #212 by providing comprehensive documentation of the machine learning models used in the uk-pvnet-app and their required inputs. The documentation is generated into a .md file, which includes a table summarizing each model, its inputs, and key configuration flags.

Fixes #212

Copy link
Contributor Author

@utsav-pal utsav-pal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this final change solve the issue

README.md Outdated
@@ -19,6 +19,32 @@ To be able to run the tests locally it is recommended to use conda & pip and fol

It is possbile to run the app locally by setting the required environment variables listed at the top of the [app](pvnet_app/app.py), these should point to the relevant data sources and DBs for the environment you want to run the app in. You will need to make sure you have opened a connection to the DB, as well as authenticating against any cloud providers where data may be stored (e.g if using AWS S3 then can do this via the AWS CLI command `aws configure`), a simple [notebook](scripts/run_app_local_example.ipynb) has been created as an example.

Copy link
Contributor

@peterdudfield peterdudfield Feb 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for having a go at this. I should have put more detail in the github issue.

I think the columns should be

  • Model name
  • Satellite
  • NWP UKV
  • NWP ECMWF
  • Legacy ( this is true if uses_ocf_data_sampler=False)
  • PVNet Hugging Face link
  • PVNet Summation Hugging Face link

For the HF link, a url needs to be made out of huggingface repo here and the version in the line below. A simialr url could be made for the summation model

Perhaps I can list them out, and then

  • pvnet_v2. This uses satellite and both nwps
  • pvnet_v2-sat0-samples-v1. This uses satellite and both nwps, but need to check this
  • pvnet_v2-sat0-only-samples-v1. Satellite only
  • pvnet_v2-ukv-only-samples-v1. Only UKV
  • pvnet_ecmwf. ECMWF only
  • pvnet_day_ahead, ECMWF and UKV
    Legacy ones
  • pvnet_v2, Satellite and both NWPs
  • pvnet_ecmwf. ECMWF only
  • pvnet_day_ahead. Satellite and both NWPs

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok I will try this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Docs on which ML models take which as inputs
2 participants