add which checks are in place in readme #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sukh-P
reviewed
Feb 18, 2025
| ## Validation Checks | ||
|
|
||
| We run a number of different validation checks on the data and the forecasts that are made. | ||
| These are in place to ensure quality forecasts are made and saved to the database. |
There was a problem hiding this comment.
Shall we specify that the forecast doesn't run if these aren't passed in some cases? Can make it clear below then in which cases this isn't the case (data filled in i.e.)
There was a problem hiding this comment.
yes, thats a good idea
Sukh-P
reviewed
Feb 18, 2025
Sukh-P
reviewed
Feb 18, 2025
Co-authored-by: Sukhil Patel <[email protected]>
Co-authored-by: Sukhil Patel <[email protected]>
Sukh-P
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Added a description of what checks are in place
#213
How Has This Been Tested?
Ci tests, but just in readme
Checklist: