Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Dockerfile): Correct version in docker container #236

Merged
merged 2 commits into from
Feb 21, 2025
Merged

fix(Dockerfile): Correct version in docker container #236

merged 2 commits into from
Feb 21, 2025

Conversation

devsjc
Copy link
Contributor

@devsjc devsjc commented Feb 20, 2025

Closes #234

@devsjc devsjc requested a review from peterdudfield February 20, 2025 16:36
@peterdudfield
Copy link
Contributor

I think there is still a fix, to get pvnet version, not pvnert app version - https://github.com/openclimatefix/uk-pvnet-app/blob/main/src/pvnet_app/app.py#L154

@devsjc
Copy link
Contributor Author

devsjc commented Feb 20, 2025

Ah I didn't realise they were different, good spot. Updated

@peterdudfield
Copy link
Contributor

Looks great

@devsjc devsjc merged commit 4b33a7b into main Feb 21, 2025
3 checks passed
@devsjc devsjc deleted the devsjc/version-fix branch February 21, 2025 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterdudfield peterdudfield peterdudfield approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: version not showing properly
2 participants
@devsjc @peterdudfield