-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: ida auth sdk #49
Conversation
"paths": { | ||
"@opencrvs/mosip-crypto": [ | ||
"../crypto/src" | ||
] | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to double-check this works with the images when deployed, but a quite simple way to setup non-compiled helper packages I hope, using moduleResolution: "bundler"
and paths
.
Wanted to abstract both crypto and ida-auth-sdk away from the more OpenCRVS related code, idealistically MOSIP engineers could create pull requests to these or even take ownership of the IDA Auth SDK later on.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You might need to copy over these packages when building the docker images
* chore: clean up jwk secret * fix: use correct dir paths
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff Pyry. Good call to keep the crypto & ida-auth stuff in their own separate packages 👍
"paths": { | ||
"@opencrvs/mosip-crypto": [ | ||
"../crypto/src" | ||
] | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You might need to copy over these packages when building the docker images
It seems to build the docker image, build with |
Implements the MOSIP IDA Auth SDK in Node.js for verifying the users details. This is a subset of the version featured in https://github.com/mosip/ida-auth-sdk/tree/release-0.9.x