Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ida auth sdk #49

Merged
merged 21 commits into from
Feb 7, 2025
Merged

feat: ida auth sdk #49

merged 21 commits into from
Feb 7, 2025

Conversation

naftis
Copy link
Contributor

@naftis naftis commented Jan 31, 2025

Implements the MOSIP IDA Auth SDK in Node.js for verifying the users details. This is a subset of the version featured in https://github.com/mosip/ida-auth-sdk/tree/release-0.9.x

package.json Show resolved Hide resolved
packages/crypto/package.json Outdated Show resolved Hide resolved
@naftis naftis added 💅 Waiting For Review Further information is requested and removed 🚧 work in progress labels Feb 5, 2025
Comment on lines +13 to +17
"paths": {
"@opencrvs/mosip-crypto": [
"../crypto/src"
]
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to double-check this works with the images when deployed, but a quite simple way to setup non-compiled helper packages I hope, using moduleResolution: "bundler" and paths.

Wanted to abstract both crypto and ida-auth-sdk away from the more OpenCRVS related code, idealistically MOSIP engineers could create pull requests to these or even take ownership of the IDA Auth SDK later on.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might need to copy over these packages when building the docker images

* chore: clean up jwk secret

* fix: use correct dir paths
Copy link
Collaborator

@Zangetsu101 Zangetsu101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff Pyry. Good call to keep the crypto & ida-auth stuff in their own separate packages 👍

Comment on lines +13 to +17
"paths": {
"@opencrvs/mosip-crypto": [
"../crypto/src"
]
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might need to copy over these packages when building the docker images

@naftis
Copy link
Contributor Author

naftis commented Feb 7, 2025

It seems to build the docker image, build with yarn tsc and run the docker image locally, but it needs a lot of environment variables so I'm not 100% sure yet if it will run on production. When this PR is ready, I will just deploy and fix the problems if they occur.

@naftis naftis merged commit 8ccd41a into main Feb 7, 2025
1 check passed
@naftis naftis deleted the ida-auth branch February 7, 2025 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💅 Waiting For Review Further information is requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants