Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pull] main from kubeflow:main #165

Merged
merged 5 commits into from
Feb 3, 2025

Conversation

pull[bot]
Copy link

@pull pull bot commented Jan 30, 2025

See Commits and Changes for more details.


Created by pull[bot] (v2.0.0-alpha.1)

Can you help keep this open source service alive? 💖 Please sponsor : )

dependabot bot and others added 2 commits January 30, 2025 16:52
Bumps [github.com/golang/glog](https://github.com/golang/glog) from 1.2.2 to 1.2.4.
- [Release notes](https://github.com/golang/glog/releases)
- [Commits](golang/glog@v1.2.2...v1.2.4)

---
updated-dependencies:
- dependency-name: github.com/golang/glog
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* feat(proxy): make the proxy resilient on mlmd failure

Signed-off-by: Alessio Pragliola <[email protected]>

* chore(proxy): simplify code by removing generic function

Signed-off-by: Alessio Pragliola <[email protected]>

* fix(proxy): prevent race condition on err channel

Signed-off-by: Alessio Pragliola <[email protected]>

---------

Signed-off-by: Alessio Pragliola <[email protected]>
Copy link

openshift-ci bot commented Jan 30, 2025

Hi @pull[bot]. Thanks for your PR.

I'm waiting for a opendatahub-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@codecov-commenter
Copy link

codecov-commenter commented Jan 30, 2025

Codecov Report

Attention: Patch coverage is 1.40187% with 422 lines in your changes missing coverage. Please review.

Project coverage is 14.48%. Comparing base (c09e98b) to head (5507207).
Report is 174 commits behind head on main.

Files with missing lines Patch % Lines
pkg/openapi/api_model_registry_service.go 0.00% 400 Missing ⚠️
internal/proxy/dynamic_router.go 0.00% 16 Missing ⚠️
pkg/api/error.go 0.00% 5 Missing ⚠️
internal/mlmdtypes/mlmdtypes.go 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #165      +/-   ##
==========================================
- Coverage   14.69%   14.48%   -0.22%     
==========================================
  Files         107      108       +1     
  Lines       28413    28834     +421     
  Branches       73       73              
==========================================
  Hits         4176     4176              
- Misses      23841    24262     +421     
  Partials      396      396              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Bumps [fossas/fossa-action](https://github.com/fossas/fossa-action) from 1.4.0 to 1.5.0.
- [Release notes](https://github.com/fossas/fossa-action/releases)
- [Commits](fossas/fossa-action@v1.4.0...v1.5.0)

---
updated-dependencies:
- dependency-name: fossas/fossa-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Al-Pragliola and others added 2 commits February 3, 2025 10:40
* chore(go): pin patch version in go.mod

Signed-off-by: Alessio Pragliola <[email protected]>

* chore(go): add toolchain directive to be less strict

Signed-off-by: Alessio Pragliola <[email protected]>

---------

Signed-off-by: Alessio Pragliola <[email protected]>
Bumps [github.com/go-logr/logr](https://github.com/go-logr/logr) from 1.4.1 to 1.4.2.
- [Release notes](https://github.com/go-logr/logr/releases)
- [Changelog](https://github.com/go-logr/logr/blob/master/CHANGELOG.md)
- [Commits](go-logr/logr@v1.4.1...v1.4.2)

---
updated-dependencies:
- dependency-name: github.com/go-logr/logr
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Copy link

@Al-Pragliola Al-Pragliola left a comment

Copy link

openshift-ci bot commented Feb 3, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Al-Pragliola, pull[bot]

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Feb 3, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit df2ec33 into opendatahub-io:main Feb 3, 2025
16 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants