Revert "feat: add onFeatureClick callback to map"

This reverts commit 1e38008.

packages/visualizations/src/components/Map/WebGl/WebGl.svelte

@@ -40,6 +40,7 @@
     $: sources = getMapSources(data.sources);
     $: layers = getMapLayers(data.layers);
     $: popupConfigurationByLayers = getPopupConfigurationByLayers(data.layers);
+
     let container: HTMLElement;
     const map = new Map();
 
@@ -54,7 +55,6 @@
     $: map.setPopupConfigurationByLayers(popupConfigurationByLayers);
     $: map.jumpTo(getCenterZoomOptions({ zoom, center: $center }));
     $: map.loadImages(images);
-    $: map.updateClickHandler(options?.onFeatureClick);
 
     // Lifecycle
     onMount(() => {

packages/visualizations/src/components/Map/WebGl/WebGl.ts

@@ -36,7 +36,6 @@ import type {
     CenterZoomOptions,
     PopupDisplayTypes,
     Images,
-    OnFeatureClick,
 } from './types';
 
 const CURSOR = {
@@ -107,9 +106,6 @@ export default class MapPOI {
     /** An array of functions to be executed when the map is ready. */
     private queuedFunctions: Array<MapFunction> = [];
 
-    /** Additional custom click handler */
-    private onFeatureClick: OnFeatureClick | null = null;
-
     /** To queue functions that depend on map readiness. Will be executed when the card is ready. */
     private queue(fn: MapFunction) {
         if (this.isReady && this.map) return fn(this.map);
@@ -244,9 +240,6 @@ export default class MapPOI {
     private onMapClick({ point }: MapLayerMouseEvent) {
         this.queue((map) => {
             this.handlePopupAfterMapClick(map, point);
-            if (this?.onFeatureClick) {
-                this.handleCustomFeatureClick(map, point, this.onFeatureClick);
-            }
         });
     }
 
@@ -399,20 +392,6 @@ export default class MapPOI {
         });
     }
 
-    private handleCustomFeatureClick(
-        map: Map,
-        point: MapMouseEvent['point'],
-        onFeatureClick: OnFeatureClick
-    ) {
-        /*
-         * Get features close to the click area.
-         * We ask for features that are not in base style layers and for which a popup config is defined.
-         */
-        const { callback, layers } = onFeatureClick;
-        const features = map.queryRenderedFeatures(point, { layers });
-        return callback(features);
-    }
-
     /**
      * Is triggered when a click has been made on the map.
      * Is responsible for opening and closing the popup.
@@ -430,7 +409,7 @@ export default class MapPOI {
      */
     private handlePopupAfterMapClick(map: Map, point: MapMouseEvent['point']) {
         /*
-         * Get features close to the click area.
+         * Get features closed to the click area.
          * We ask for features that are not in base style layers and for which a popup config is defined.
          */
         const features = map.queryRenderedFeatures(point, {
@@ -511,6 +490,7 @@ export default class MapPOI {
         options: Omit<MapOptions, 'style' | 'container'>
     ) {
         this.map = new MaplibreGl.Map({ style, container, ...options });
+
         this.queue((map) => this.initializeMapResizer(map, container));
         this.queue((map) => this.initializeCursorBehavior(map));
 
@@ -593,12 +573,6 @@ export default class MapPOI {
         });
     }
 
-    updateClickHandler(handler?: OnFeatureClick) {
-        if (handler) {
-            this.onFeatureClick = handler;
-        }
-    }
-
     /**
      * Changes any combination of center and zoom without an animated transition.
      * The map will retain its current values for any details not specified in options

packages/visualizations/src/components/Map/WebGl/types.ts

@@ -4,7 +4,6 @@ import type {
     GeoJSONFeature,
     GestureOptions,
     LngLatLike,
-    MapGeoJSONFeature,
     RequestTransformFunction,
     StyleImageMetadata,
     StyleSpecification,
@@ -20,11 +19,6 @@ export type WebGlMapData = Partial<{
     layers: Layer[];
 }>;
 
-export type FeatureClickHandler = (f: MapGeoJSONFeature[]) => void;
-export type OnFeatureClick = {
-    callback: FeatureClickHandler;
-    layers: string[];
-};
 export interface WebGlMapOptions {
     /*
      * To render a basemap. Could be:
@@ -58,8 +52,6 @@ export interface WebGlMapOptions {
     preserveDrawingBuffer?: boolean;
     /** Images to load by the Map. keys are image ids  */
     images?: Images;
-    /** An addiational callback to be triggered when clicking a feature */
-    onFeatureClick?: OnFeatureClick;
 }
 
 export type WebGlMapStyleOption = Partial<Pick<StyleSpecification, 'sources' | 'layers'>>;