Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev(hansbug): add fallback for rick logging #9

Merged
merged 2 commits into from
Jan 17, 2024
Merged

dev(hansbug): add fallback for rick logging #9

merged 2 commits into from
Jan 17, 2024

Conversation

HansBug
Copy link
Member

@HansBug HansBug commented Jan 17, 2024

For #8

@HansBug HansBug added the bug Something isn't working label Jan 17, 2024
@HansBug HansBug self-assigned this Jan 17, 2024
Copy link

codecov bot commented Jan 17, 2024

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (fc9007e) 97.12% compared to head (106e72e) 96.15%.

Files Patch % Lines
ditk/logging/terminal.py 37.50% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main       #9      +/-   ##
==========================================
- Coverage   97.12%   96.15%   -0.98%     
==========================================
  Files          18       18              
  Lines         487      494       +7     
==========================================
+ Hits          473      475       +2     
- Misses         14       19       +5     
Flag Coverage Δ
unittests 96.15% <37.50%> (-0.98%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HansBug HansBug requested a review from PaParaZz1 January 17, 2024 05:47
@HansBug
Copy link
Member Author

HansBug commented Jan 17, 2024

close #8

@HansBug HansBug closed this Jan 17, 2024
@HansBug HansBug reopened this Jan 17, 2024
@HansBug HansBug merged commit 0b68b26 into main Jan 17, 2024
17 of 18 checks passed
@HansBug HansBug deleted the dev/fallback branch January 17, 2024 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants