Use odrcode http #380
Draft
Use odrcode http #380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
andiwand
commented
Jan 10, 2025
andiwand
commented
- Switch to use http for new odrcore
- Use odrcode pdf2htmlex
- Allows lazy loading for pdf
andiwand
commented
Jan 19, 2025
Comment on lines
+130
to
+131
| // TODO can and should this be architecture dependent? | ||
| sourceSets.main.assets.srcDirs += "build/conan/armv8/assets" |
There was a problem hiding this comment.
@TomTasche not sure if this is even relevant
There was a problem hiding this comment.
I guess the assets we care about are not arch-dependent? still makes sense to keep the TODO in case someone considers adding arch-dependent assets...
| odrcore/4.1.1@ | ||
| odrcore/9.9.9@ |
There was a problem hiding this comment.
TODO: use newly tagged version when it is published
| @@ -49,6 +49,7 @@ | |||
| android:label="@string/app_title" | |||
| android:roundIcon="@mipmap/ic_launcher_round" | |||
| android:theme="@style/MainTheme" | |||
| android:networkSecurityConfig="@xml/network_security_config" | |||
There was a problem hiding this comment.
@TomTasche this was necessary to get HTTP working. without that we have to use HTTPS
| JNIEXPORT void JNICALL | ||
| Java_at_tomtasche_reader_background_CoreWrapper_listenServerNative(JNIEnv *env, jclass clazz) { | ||
| s_server->listen("127.0.0.1", 29665); |
| String id = CoreWrapper.hostFile(coreOptions); | ||
|
|
||
| result.partTitles.add("document"); | ||
| result.partUris.add(Uri.parse("http://localhost:29665/" + id + "/document.html")); |
Comment on lines
-125
to
+151
| loader = odfLoader; | ||
| loader = coreHttpLoader; | ||
| break; | ||
| case DOC: | ||
| loader = docLoader; | ||
| loader = coreHttpLoader; | ||
| break; | ||
| case OOXML: | ||
| loader = ooxmlLoader; | ||
| loader = coreHttpLoader; | ||
| break; | ||
| case PDF: | ||
| loader = pdfLoader; | ||
| loader = coreHttpLoader; |
| @@ -5,11 +5,11 @@ | |||
|
|
|||
| public class CoreWrapper { | |||
|
|
|||
| public void initialize() { | |||
| static { | |||
| System.loadLibrary("odr-core"); | |||
There was a problem hiding this comment.
TODO: communicate data paths for core
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.