feat(helm): add list of container images #549
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiagolobocastro
force-pushed
the
helm-images
branch
from
cf808f6 to
68e3309
Compare
Adds a list of container images which are used by the chart. This list is contained in file: charts/images.txt Sometimes the images can't be figured out using templates, and in such cases we need to manually add them. charts/dependencies-images.txt is covering the this for the dependencies. Signed-off-by: Tiago Castro <[email protected]>
tiagolobocastro
force-pushed
the
helm-images
branch
from
68e3309 to
6d37394
Compare
niladrih
reviewed
Sep 30, 2024
Comment on lines
+15
to
+23
| echo_stderr() { | ||
| echo -e "${1}" >&2 | ||
| } | ||
|
|
||
| die() { | ||
| local _return="${2:-1}" | ||
| echo_stderr "$1" | ||
| exit "${_return}" | ||
| } |
There was a problem hiding this comment.
There's /scripts/utils/log.sh you could source and use log_fatal or log_error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a list of container images which are used by the chart. This list is contained in file: charts/images.txt
Sometimes the images can't be figured out using templates, and in such cases we need to manually add them.
charts/dependencies-images.txt is covering the this for the dependencies.