Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Fix invalid YAMLs #611

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Conversation

nilroy
Copy link

@nilroy nilroy commented Jan 28, 2025

Description

Fix invalid YAMLs in CRDS. Continuing from this PR

Motivation and Context

Regression

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added unit tests to cover my changes.

@Abhinandan-Purkait Abhinandan-Purkait dismissed their stale review January 29, 2025 05:11

Seems like chart lint failed.

Copy link
Contributor

@tiagolobocastro tiagolobocastro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please amend your commit to follow conventional commit of, example:
fix(crd): fix invalid snapshot crd yaml

@nilroy
Copy link
Author

nilroy commented Jan 29, 2025

Please amend your commit to follow conventional commit of, example: fix(crd): fix invalid snapshot crd yaml

@tiagolobocastro I renamed the commit message. But I am not sure what kind of linting check is done on the CRDs. I just copied them over from the original PR. Could help me here?

@tiagolobocastro
Copy link
Contributor

Please amend your commit to follow conventional commit of, example: fix(crd): fix invalid snapshot crd yaml

@tiagolobocastro I renamed the commit message. But I am not sure what kind of linting check is done on the CRDs. I just copied them over from the original PR. Could help me here?

Don't see anything wrong with the CRDs, Helm Chart CI is passing, @Abhinandan-Purkait what did you mean by "chart lint failed" ? Did you confuse it with the commit lint somehow?

@tiagolobocastro
Copy link
Contributor

@nilroy we use bors which does a merge itself, so you don't need to put a merge on your commit, in fact this will be rejected by CI.
Please bring only the fix(crd): fix invalid snapshot crd yaml commit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants