-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix] Fix invalid YAMLs #611
base: develop
Are you sure you want to change the base?
Conversation
Seems like chart lint failed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please amend your commit to follow conventional commit of, example:
fix(crd): fix invalid snapshot crd yaml
Signed-off-by: Nilanjan Roy <[email protected]>
@tiagolobocastro I renamed the commit message. But I am not sure what kind of linting check is done on the CRDs. I just copied them over from the original PR. Could help me here? |
Don't see anything wrong with the CRDs, Helm Chart CI is passing, @Abhinandan-Purkait what did you mean by "chart lint failed" ? Did you confuse it with the commit lint somehow? |
@nilroy we use bors which does a merge itself, so you don't need to put a merge on your commit, in fact this will be rejected by CI. |
Description
Fix invalid YAMLs in CRDS. Continuing from this PR
Motivation and Context
Regression
How Has This Been Tested?
Types of changes
Checklist: