-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: restructured local engine (hostpath, lvm, and zfs) #404
Conversation
Hello @avishnu, please review the suggested changes and share your feedback if any, or approve the PR. If all looks good, please merge the PR by EOB. Thanks! |
Signed-off-by: Gincy Thomas <[email protected]>
Signed-off-by: Gincy Thomas <[email protected]>
Signed-off-by: Gincy Thomas <[email protected]>
Signed-off-by: Gincy Thomas <[email protected]>
Signed-off-by: Gincy Thomas <[email protected]>
…on file Signed-off-by: Gincy Thomas <[email protected]>
Signed-off-by: Gincy Thomas <[email protected]>
32d1223
to
92410d5
Compare
Signed-off-by: Gincy Thomas <[email protected]>
docs/main/user-guides/local-engine-user-guide/local-pv-lvm/advanced-operations/lvm-resize.md
Outdated
Show resolved
Hide resolved
docs/main/user-guides/local-engine-user-guide/local-pv-lvm/advanced-operations/lvm-resize.md
Show resolved
Hide resolved
docs/main/user-guides/local-engine-user-guide/local-pv-lvm/advanced-operations/lvm-resize.md
Outdated
Show resolved
Hide resolved
...ser-guides/local-engine-user-guide/local-pv-lvm/advanced-operations/lvm-thin-provisioning.md
Show resolved
Hide resolved
docs/main/user-guides/local-engine-user-guide/local-pv-lvm/lvm-deployment.md
Outdated
Show resolved
Hide resolved
docs/main/user-guides/local-engine-user-guide/local-pv-lvm/lvm-deployment.md
Show resolved
Hide resolved
docs/main/user-guides/local-engine-user-guide/local-pv-lvm/lvm-deployment.md
Show resolved
Hide resolved
docs/main/user-guides/local-engine-user-guide/local-pv-lvm/lvm-deployment.md
Show resolved
Hide resolved
docs/main/user-guides/local-engine-user-guide/local-pv-lvm/lvm-deployment.md
Outdated
Show resolved
Hide resolved
docs/main/user-guides/local-engine-user-guide/local-pv-lvm/lvm-deployment.md
Show resolved
Hide resolved
docs/main/user-guides/local-engine-user-guide/local-pv-zfs/advanced-operations/zfs-clone.md
Show resolved
Hide resolved
docs/main/user-guides/local-engine-user-guide/local-pv-zfs/advanced-operations/zfs-clone.md
Show resolved
Hide resolved
...user-guides/local-engine-user-guide/local-pv-zfs/advanced-operations/zfs-raw-block-volume.md
Show resolved
Hide resolved
...user-guides/local-engine-user-guide/local-pv-zfs/advanced-operations/zfs-raw-block-volume.md
Show resolved
Hide resolved
docs/main/user-guides/local-engine-user-guide/local-pv-zfs/advanced-operations/zfs-resize.md
Show resolved
Hide resolved
docs/main/user-guides/local-engine-user-guide/local-pv-zfs/advanced-operations/zfs-resize.md
Show resolved
Hide resolved
Signed-off-by: Gincy Thomas <[email protected]>
docs/main/user-guides/local-engine-user-guide/local-pv-hostpath/hostpath-configuration.md
Outdated
Show resolved
Hide resolved
docs/main/user-guides/local-engine-user-guide/local-pv-hostpath/hostpath-configuration.md
Outdated
Show resolved
Hide resolved
docs/main/user-guides/local-engine-user-guide/local-pv-hostpath/hostpath-installation.md
Show resolved
Hide resolved
@Abhinandan-Purkait @niladrih this PR has package-lock.json and yarn.lock changes. Though they might have ended up here un-intentionally, wondering if we should consider taking in the changes as they seem to be updating lots of packages IIANW |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On the package updates -- the sample seems to build, looks fine. So I'd say it's a good idea to take this in. Should be a separate commit though, so that we could revert it if something breaks.
You mean both package-lock.json and yarn.lock? |
Signed-off-by: Gincy Thomas <[email protected]>
docs/main/user-guides/local-engine-user-guide/local-pv-hostpath/hostpath-configuration.md
Show resolved
Hide resolved
No we aren't suppose to take that in. It got created because they ran the server locally, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, good PR.
3c87d22
to
e3b1c28
Compare
Signed-off-by: Gincy Thomas <[email protected]>
e3b1c28
to
d68c9b2
Compare
No description provided.