fix: fixed getting a users' name on UserData collections

openedx · Jan 14, 2025 · c05cd1e · c05cd1e
1 parent 81f825f
commit c05cd1e
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/lms/djangoapps/grades/events.py b/lms/djangoapps/grades/events.py
@@ -286,7 +286,7 @@ def _emit_course_passing_status_update(user, course_id, is_passing):
                     pii=UserPersonalData(
                         username=user.username,
                         email=user.email,
-                        name=user.get_full_name(),
+                        name=user.get_full_name() or user.profile.name,
                     ),
                     id=user.id,
                     is_active=user.is_active,
@@ -305,7 +305,7 @@ def _emit_course_passing_status_update(user, course_id, is_passing):
                     pii=UserPersonalData(
                         username=user.username,
                         email=user.email,
-                        name=user.get_full_name(),
+                        name=user.get_full_name() or user.profile.name,
                     ),
                     id=user.id,
                     is_active=user.is_active,

diff --git a/lms/djangoapps/grades/tests/test_events.py b/lms/djangoapps/grades/tests/test_events.py
@@ -161,7 +161,7 @@ def test_course_passing_status_updated_emitted(self):
                         pii=UserPersonalData(
                             username=self.user.username,
                             email=self.user.email,
-                            name=self.user.get_full_name(),
+                            name=self.user.get_full_name() or self.user.profile.name,
                         ),
                         id=self.user.id,
                         is_active=self.user.is_active,
@@ -234,7 +234,7 @@ def test_ccx_course_passing_status_updated_emitted(self):
                         pii=UserPersonalData(
                             username=self.user.username,
                             email=self.user.email,
-                            name=self.user.get_full_name(),
+                            name=self.user.get_full_name() or self.user.profile.name,
                         ),
                         id=self.user.id,
                         is_active=self.user.is_active,

diff --git a/lms/djangoapps/verify_student/signals/signals.py b/lms/djangoapps/verify_student/signals/signals.py
@@ -27,7 +27,7 @@ def _create_user_data(user):
         pii=UserPersonalData(
             username=user.username,
             email=user.email,
-            name=user.get_full_name()
+            name=user.get_full_name() or user.profile.name
         )
     )